Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle classic image generation and generate for beta 1 #413

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle classic image generation and generate for beta 1 #413

wants to merge 1 commit into from

Conversation

tleon
Copy link

@tleon tleon commented Feb 10, 2025

Questions Answers
Description? Changed the generate script to handle classic suffixes in version. Generated the classic version for the 9.0.0-beta-1-classic
Type? improvement
BC breaks? no
Deprecations? no
Sponsor company PrestaShop SA
How to test? CI green

@ps-jarvis
Copy link

Hello @tleon!

This is your first pull request on docker repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@tleon tleon self-assigned this Feb 10, 2025
@tleon tleon force-pushed the Handle-clasic-version-generation branch 6 times, most recently from 8cb89f0 to b88a6ac Compare February 10, 2025 16:47
matks
matks approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Progi1984
Progi1984 reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple suggestion : add an unit test via a flavor as classic

And it will be ✔️ for me.

@tleon tleon force-pushed the Handle-clasic-version-generation branch from b88a6ac to 3f8b05c Compare February 11, 2025 17:30
@tleon tleon force-pushed the Handle-clasic-version-generation branch from 3f8b05c to 6f96d93 Compare February 11, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 left review comments

@nicosomb nicosomb nicosomb approved these changes

@matks matks matks approved these changes

@boherm boherm boherm approved these changes

Assignees

@tleon tleon

Labels
None yet
Projects
PR Dashboard
Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tleon @ps-jarvis @nicosomb @Progi1984 @matks @boherm