Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SCSS variables to storybook #139

Merged
merged 5 commits into from
May 17, 2021
Merged

Add SCSS variables to storybook #139

merged 5 commits into from
May 17, 2021

Conversation

NeOMakinG
Copy link
Contributor

Questions Answers
Description? External users had no way of reading SCSS variables without having the repository opened, now it's automatically updated inside storybook
Type? improvement
BC breaks? no
Deprecations? no
How to test? npm run storybook and read variables section

image
image

@NeOMakinG NeOMakinG added WIP and removed WIP labels Mar 1, 2021
@NeOMakinG NeOMakinG requested a review from a team March 1, 2021 14:23
@PierreRambaud
Copy link
Contributor

Can be tested by dev I think :)

@Progi1984
Copy link
Member

@PierreRambaud :
Can be tested by dev I think :)

@PrestaShop/qa-functional : OK for a QA Dev ?

@NeOMakinG
Copy link
Contributor Author

I agree, it should be fine :)

@Robin-Fischer-PS
Copy link

@NeOMakinG @Progi1984 OK for QA by dev, thanks :)

@NeOMakinG NeOMakinG added this to the 1.2.3 milestone Mar 17, 2021
@NeOMakinG NeOMakinG modified the milestones: 1.2.3, 1.2.4 Apr 15, 2021
@NeOMakinG NeOMakinG merged commit f8557fe into PrestaShop:develop May 17, 2021
@NeOMakinG
Copy link
Contributor Author

Thanks for testing @PierreRambaud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiix atomiix atomiix approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.
5 participants
@NeOMakinG @PierreRambaud @Progi1984 @Robin-Fischer-PS @atomiix