Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hover state on helpbox and add helpbox to storybook #156

Merged
merged 2 commits into from
May 12, 2021
Merged

Add hover state on helpbox and add helpbox to storybook #156

merged 2 commits into from
May 12, 2021

Conversation

NeOMakinG
Copy link
Contributor

Questions Answers
Description? Helpboxes needed an hover state and wasn't on the storybook
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#24317.
How to test? Run npm i && npm run storybook and see on Helpbox if it contains the hover state
Possible impacts? Helpbox on hover

@NeOMakinG NeOMakinG added this to the 1.2.4 milestone May 11, 2021
@Progi1984 Progi1984 merged commit 522b6c4 into PrestaShop:develop May 12, 2021
@Progi1984
Copy link
Member

Thanks @NeOMakinG & @sarahdib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.

[UI Kit] Updating tooltips colors
4 participants
@NeOMakinG @Progi1984 @PierreRambaud @sarahdib