Renew PrestaShop UI Kit branding #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tblivet
commented
Jul 22, 2024
•
tblivet
commented
| Questions | Answers |
|---|---|
| Description? | Renew PrestaShop UI Kit branding, agreed by @matks |
| Type? | new feature |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed ticket? | See PrestaShop/PrestaShop#36615 |
| Sponsor company | @PrestaShopCorp |
| How to test? |
|
Hello @tblivet! This is your first pull request on prestashop-ui-kit repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
7 tasks
jolelievre
reviewed
Jul 25, 2024
There was a problem hiding this comment.
Great job @tblivet
I just have a few questions to understand the new convention in variables I also think this should be documented so that developers understand the logic behind it If it's not documented and explained I'm afraid people won't use the new convention and all the huge cleaning job you did in the core will be wasted as time goes on
mattgoud
approved these changes
Jul 31, 2024
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.