-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds actionObjectProductCommentAddAfter action hook #139
base: dev
Are you sure you want to change the base?
Conversation
samberrry
commented
May 10, 2022
•
edited by kpodemski
Loading
edited by kpodemski
Questions | Answers |
---|---|
Description? | This action hook is necessary for this feature: PrestaShop/ps_facetedsearch#569. In PostComment front controller the PostComment entity is being used instead of ObjectModel, so we do not get addAfter event. |
Type? | new feature |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | n/a, developer feature |
How to test? | after adding a comment from front office hook "actionObjectProductCommentAddAfter" should be executed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @samberrry
Thanks! Sorry for the late reply. Let's move this topic of Faceted search improvements forward :)
I've added a minor suggestion to be more explicit with the argument.
Also, could you please create a simple feature request with the link to your two PRs and a description so we can have it validated by the QA?
Co-authored-by: Krystian Podemski <kpodemski@users.noreply.github.com>
Hey @kpodemski, Yes, let's move it. And, where should I create the feature request? on the ps_facetedsearch repo? |
@kpodemski @samberrry I see one problematic thing here guys. This hook normally sends the ObjectModel instance as a parameter ( |
@Hlavtox, you're absolutely right, I guess it'll be enough o pass |