-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Review Microdata to product #158
base: dev
Are you sure you want to change the base?
Conversation
I think we removed it some time ago. The review data should be put in the header, is not the case? |
In that case I'm ok, but for me there's no review in any part of the page... |
Sorry. |
I made a PR long time ago to expose reviews to use in header. This involves the modification of the template, but it is still open... |
Hi @rodriciru I think it is not needed anymore, as we should have reviews info in JSON-LD :) |
Great. But as for the moment, there's no such info (not even in the JSON_LD) this fix that for all templates that use this module. |
@Hlavtox @kpodemski @rodriciru How can we move forward? Looks like discussion is stuck on a disagreement |
I will summarize.
|
I'm not a PrestaShop dev, so my understanding of PrestaShop is limited. Anyway, I do my best Anyway, if has such info in microdata is a problem, we can close this PR and look to this PR #140 which populates comments, and reviews, so every template can make use of it in the way the want |
Currently, there's no schema markup for review.
Google complains about it, so this PR fixed that.