-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update list-comments.js #163
base: dev
Are you sure you want to change the base?
Conversation
djbuch
commented
May 25, 2023
Questions | Answers |
---|---|
Description? | Correct a bug, where stars on additionnal products on a product page would have wrong star number, because the stars where inited before the grade retrivial |
Type? | bug fix |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | |
How to test? | View a product page with additionnal products having comments, without this correction they would alwas have only one star. |
Correct a bug, where stars on additionnal products on a product page would have wrong star number, because the stars where inited before the grade retrivial
Hi @djbuch Good to see you again in the project! Have you tried to do something like:
maybe that would help with the issues you have. otherwise, it's hard for me to understand why your code would be different if we target the same selectors, eventually |
Hello, we are not targeting the same selectors, in fact I added a more
specific selector before, in order to avoid to target all .grade-stars
Regards,
Le jeu. 25 mai 2023 à 14:42, Krystian Podemski ***@***.***> a
écrit :
… Hi @djbuch <https://github.com/djbuch>
Good to see you again in the project! Have you tried to do something like:
setTimeout(function() {
$('.grade-stars').rating();
}, 0);
maybe that would help with the issues you have. otherwise, it's hard for
me to understand why your code would be different if we target the same
selectors, eventually
—
Reply to this email directly, view it on GitHub
<#163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLAMXABCT4D3ICLRMVGBQDXH5HVDANCNFSM6AAAAAAYOQISMM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @djbuch |
Hello, Nevertheless I remember it was the only way to correct this bug effectively. It is never a good idea to use to large selectors, as other module can need to init rating(), and sometimes on an async basis. Regards, |
I'm guessing it's for the product page where you have Although this main rating on the product page may be in several places so we might need further changes to cover all of them. |