if last name is anonymous - replace lastname variable from response
#171
Conversation
mjamroz
commented
Jun 21, 2023
•
mjamroz
commented
| Questions | Answers |
|---|---|
| Description? | Remove last name from response if anonymized name |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| @@ -71,6 +71,7 @@ public function display() | |||
|
|
|||
| if ($isLastNameAnonymous) { | |||
| $productComment['customer_name'] = $this->anonymizeName($productComment['customer_name']); | |||
| $productComment['lastname']= '...'; | |||
There was a problem hiding this comment.
what does $productComment['customer_name'] contain ? is it the first name ? in this case we should concatenate customer_name and lastname before sending it to the anonymizeName method.
If it's just a name I guess it's fine 🤔
I ask this because I see the anonymizeName method does split the parameter with a space, as if expecting a name in two parts
There was a problem hiding this comment.
I'm quite sure that if we want to improve Lastname anonymizing, we need to do it inside function anonymizeName (lines 96 - 112), or before calling it at line 73.
There was a problem hiding this comment.
@matthieu-rolland customer_name contains first_name + last_name.
There was a problem hiding this comment.
thank you @mjamroz for your PR 👍 just one question, as I'm not familiar with this module
