Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded version check #192

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Remove unneeded version check #192

merged 2 commits into from
Dec 30, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Dec 30, 2023

Questions Answers
Description? Removes forgotten version check. Minimum core version is higher than what this check is doing.
Type? refacto
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? No need, syntax is covered by tests.

@Hlavtox Hlavtox added this to the 6.0.3 milestone Dec 30, 2023
@Hlavtox Hlavtox merged commit e53bfe8 into PrestaShop:dev Dec 30, 2023
8 checks passed
@leemyongpakvn
Copy link
Contributor

@Hlavtox FYI ProductCommentCriterion ObjectModel is unused since v6.0.0 (L274-L275) and will be removed in v7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaiMagal ShaiMagal ShaiMagal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
6.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Hlavtox @leemyongpakvn @ShaiMagal