Fixing the bug that appeared when anonymize customer last name option has been added. #89
Conversation
Oksydan
commented
Dec 9, 2020
Oksydan
commented
| Questions | Answers |
|---|---|
| Description? | Fixing the bug that appeared when anonymize customer last name option has been added. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#22222. |
| How to test? | Issue describes it enough. |
controllers/front/ListComments.php
Outdated
| @@ -65,7 +65,7 @@ public function display() | |||
| $productComment['content'] = htmlentities($productComment['content']); | |||
| $productComment['date_add'] = $dateFormatter->format($dateAdd); | |||
|
|
|||
| if ($isLastNameAnynomus) { | |||
| if ($isLastNameAnynomus && isset($productComment['firstname']) && isset($productComment['lastname'])) { | |||
There was a problem hiding this comment.
Hello
What's the idea behind checking if firstname is set if we don't use it in the condition ?
There was a problem hiding this comment.
Hi,
isset($productComment['firstname']) && isset($productComment['lastname']) - for deleting account firstname and lastname is not set. I just want to be sure that nothing weird are going to happen when first name will not be available.
There was a problem hiding this comment.
Well, you are right. Check exists on line 74.
|
CSFixer is red, please run it :) |
|
Cs fixer is red for a bad reason. |
|
@PierreRambaud I did it against latest dev branch with your CS fixer changes. |
|
@Oksydan I don't know how you rebased your PR but something's wrong 🤔, you shouldn't see someone else's commits on your PR. |
Oksydan
force-pushed
the
anonymize-user-fix
branch
from
40500bd
to
9710c7a
Compare
|
@atomiix |
|
Hi @Oksydan, It is ok ✔️ Thanks! |
|
Thank you @Oksydan |
