Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ps_emailalerts does not save creation time of request for notification #30186

Open
6 tasks done
lmeyer1 opened this issue Nov 2, 2022 · 1 comment · May be fixed by PrestaShop/ps_emailalerts#120
Open
6 tasks done
Labels
BO Category: Back Office Feature Type: New Feature Module Module Needs Specs Status: issue needs to be specified ps_emailalerts Module: Mail Alerts

Comments

@lmeyer1
Copy link
Contributor

lmeyer1 commented Nov 2, 2022

Prerequisites

Is your feature request related to a problem?

I installed ps_emailalerts, and I reviewed the alerts the customer subscribed to in the table ps_mailalert_customer_oos. Unfortunately, the time when a customer or visitor subscribed to a product alert is not saved. Therefore, the data is not useful for the merchant.
Also, when a customer is notified, then the notification is deleted. This does not allow the merchant to know if the module is efficient in notifying his customers.

Related to #28233 ps_emailalerts: As a merchant be informed about customers subscribing to product availability notifications.

Describe the solution you'd like

The table ps_mailalert_customer_oos must contain the date at which the user requested a notification. This is required to answer these questions, and any other question a merchant could ask about notifications for products out of stock:

  • How long are my customers waiting for a product?
  • What new notifications were requested last week?
  • A product has many requests for notification. Are they old or recent?

The table also must support soft delete instead of hard delete. There are three reasons to delete a notification (customer notified, product deleted, by customer request (gdpr)). The date the notification was sent would also be interesting. I see two ways to solve this:

  • field (datetime) date_deleted with (bool) notified
  • field (bool) deleted with (datetime) date_notified

Alternatives you've considered

There is no alternative

Additional context

No response

Do you plan to work on this feature?

  • I'm willing to contribute a formal specification.
  • I'm willing to provide any wireframes or design assets required for this feature.
  • I'm willing to submit a Pull Request that implements this feature.
  • I'm willing to help verify that the implemented feature works as intended and produces no unintended side effects.
@lmeyer1 lmeyer1 added Feature Type: New Feature New New issue not yet processed by QA labels Nov 2, 2022
@lmeyer1 lmeyer1 changed the title ps_emailalerts does not save creation time of alert ps_emailalerts does not save creation time of request for notification Nov 2, 2022
@AureRita
Copy link
Contributor

AureRita commented Nov 3, 2022

Hi @lmeyer1 ,

Thank you for your suggestion. The Maintainer Team will take it into consideration for future developments.

Waiting for your PR 🚀

Thank you

@AureRita AureRita added BO Category: Back Office Needs Specs Status: issue needs to be specified ps_emailalerts Module: Mail Alerts Module Module and removed New New issue not yet processed by QA labels Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BO Category: Back Office Feature Type: New Feature Module Module Needs Specs Status: issue needs to be specified ps_emailalerts Module: Mail Alerts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants