-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add date_add, date_upd, soft delete and notification send time #120
base: dev
Are you sure you want to change the base?
Conversation
The soft delete is very interesting 👍, let's understand how to manage on legal side tho |
I missed to delete all customer data. But once this is fixed, there should not remain any legal problem. Don't you think ? |
Waiting for you @lmeyer1 😉 |
This PR is blocking 2.4.2 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@lmeyer1 can you rebase maybe on the latest version of the dev branch to avoid merge worries ? |
For information, the install function has a bug preventing database creation: missing coma at the end of line 139
|
@LouisAUTHIE I hope the rebase was successful. |
ps_mailalert_customer_oos
, in order for merchant to be able to analyze customer needs and behavior.There are these improvements in the db:
date_add
notification_sent
and the line is soft-deleted.