Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespaces naming #13

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix namespaces naming #13

merged 2 commits into from
Jun 13, 2024

Conversation

matthieu-rolland
Copy link
Contributor

@matthieu-rolland matthieu-rolland commented Jun 13, 2024 •
edited
Loading

Questions Answers
Description? revert change of namespace
Type? refactor
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company PrestaShop
How to test?

matks
matks approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better this way as it is more compliant with convention

@matks matks merged commit 5b425e3 into PrestaShop:main Jun 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@boherm boherm boherm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthieu-rolland @matks @boherm