Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACCOUNT-2522] feat: bakend login compat v9 #431

Open
wants to merge 83 commits into
base: main
Choose a base branch
from
Open

[ACCOUNT-2522] feat: bakend login compat v9 #431

wants to merge 83 commits into from

Conversation

hschoenenberger
Copy link
Contributor

@hschoenenberger hschoenenberger commented Aug 14, 2024 •
edited
Loading

  • Finalize module cache management
  • Login page i18n (sf version)

@hschoenenberger
feat: new vendor dependency to scope (psr)
575c596
@hschoenenberger
feat: new vendor dependency to scope (symfony)
8306689
@hschoenenberger
fix: typos in psr4 namespaces
eeef5ce
@hschoenenberger
fix: typos in psr4 namespaces
964f7f1
@hschoenenberger
fix: missing scoping dependencies
7599212
@hschoenenberger
fix: phpstan
837f29d
@hschoenenberger
Merge remote-tracking branch 'origin/main' into ACCOUNT-2545/feat/psr…
9330b97 
…-scoping

# Conflicts:
#	Makefile
@hschoenenberger
fix: safety check
1623114
@hschoenenberger
fix: safety check
73a3ec7
@hschoenenberger
fix: php-cs-fixer
c79f521
@hschoenenberger
fix: php-cs-fixer
5c4a935
@hschoenenberger
Merge remote-tracking branch 'origin/main' into ACCOUNT-2545/feat/psr…
e963954 
…-scoping

# Conflicts:
#	Makefile
#	src/Log/Logger.php
@hschoenenberger
fix: removed target
7f8744f
@hschoenenberger
fix: typehint
4210933
@hschoenenberger
feat: scoping ramsey/uuid
f4d09a2
@hschoenenberger
feat: scoping paragonie/random_compat
ee0341b
@hschoenenberger
feat: scoping ralouphie, phpseclib
aa9dfef
@hschoenenberger
feat: scoping paragonie/random_compat
73b7c5a
@hschoenenberger
feat: catch middleware exceptions
ee7603f
@hschoenenberger
fix: getSession for ps9
08c72f7
@hschoenenberger
feat: compat trait
59ca47d
@hschoenenberger
refactor: move trait
7cd9eea
@hschoenenberger
fix: more logs
0746edf
@hschoenenberger
refactor: preserve previous parameter
8e6ff60
@hschoenenberger
fix: use setter instead of overriding method
6850c99
@hschoenenberger
feat: add a logger member
9067cb7
@hschoenenberger
fix: comment code
5d858a1
@hschoenenberger
refactor: login & repository exception management
c35223e
@hschoenenberger
Merge remote-tracking branch 'origin/main' into ACCOUNT-2545/feat/psr…
57d1d41 
…-scoping
@hschoenenberger
fix: php-cs-fixer
3a4bc36
@hschoenenberger hschoenenberger added the enhancement New feature or request label Oct 22, 2024
@hschoenenberger hschoenenberger marked this pull request as ready for review October 24, 2024 15:56
@hschoenenberger hschoenenberger changed the title [ACCOUNT-2522] feat: bakend login - prestashop v9 [ACCOUNT-2522] feat: bakend login compat v9 Oct 24, 2024
antoinemetifeu
antoinemetifeu reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@antoinemetifeu antoinemetifeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dans l'ensemble, le code me parait ok. Peut-être 2-3 blocs de code commentés par ci par là qui pourrait être nettoyé.

Je vais essayer de rapidement tester sur une v9 et une ancienne version avant de laisser la PR aux mains de la QA :)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinemetifeu antoinemetifeu antoinemetifeu left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@hschoenenberger hschoenenberger

Labels
enhancement New feature or request ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hschoenenberger @antoinemetifeu