-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New GRPC Build System #1
Conversation
The latest Buf updates on your PR. Results from workflow Validate Pull Request / check_buf (pull_request).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! Only a couple things:
- I mentioned this in the review itself, but the formatting for these files is not the same as our typical setup. Was the a reason for this?
- I know that the building has been moved to
npm
rather thanmake
now (which is fine 👍) so it makes sense to keep thepackage.json
in the root, but why is the Go files also in the root? It's not a HUGE deal, I'm just curious since it looks a bit odd to be mixing language files like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chatgpt approves this, so should be good
What's left to do:
NPM_TOKEN
secret to allow publishing to npm