Add parasolr last modified mixin (#375)

[kmcelwee]

• We want to track all fields correct? Let me know if I should add a filter.
• Looks like next time we do a release for parasolr we should make sure to rebuild the docs. https://parasolr.readthedocs.io/en/latest/search.html?q=SolrLastModifiedMixin&check_keywords=yes&area=default

[rlskoeser]

For the search I think we do want all documents — we only include public/non-suppressed documents in the search, but if a document was marked as suppressed that should be reflected in the search last-modified.

For the document detail views, we want the last modification for the single document being viewed. Please apply to all document detail views — perhaps generalize/rename DocumentPastIdMixin to a document detail base class and add the last-modified behavior there.

[rlskoeser]

* Looks like next time we do a release for parasolr we should make sure to rebuild the docs. https://parasolr.readthedocs.io/en/latest/search.html?q=SolrLastModifiedMixin&check_keywords=yes&area=default

I'm not sure the view was added to the code docs, please check. (I didn't even remember the view had been generalized and moved to parasolr)

[kmcelwee]

@rlskoeser

For the search I think we do want all documents — we only include public/non-suppressed documents in the search, but if a document was marked as suppressed that should be reflected in the search last-modified.

I tried testing this, and it seems to work as is. Would you mind confirming that this is testing the behavior you're looking for? 2bd1b05

[rlskoeser]

@rlskoeser

For the search I think we do want all documents — we only include public/non-suppressed documents in the search, but if a document was marked as suppressed that should be reflected in the search last-modified.

I tried testing this, and it seems to work as is. Would you mind confirming that this is testing the behavior you're looking for? 2bd1b05

Yes, the existing logic is correct; this is a good test to confirm it.

[kmcelwee]

I'm not sure the view was added to the code docs, please check. (I didn't even remember the view had been generalized and moved to parasolr)

It wasn't. I made a PR: Princeton-CDH/parasolr#71

[kmcelwee]

For the document detail views, we want the last modification for the single document being viewed. Please apply to all document detail views — perhaps generalize/rename DocumentPastIdMixin to a document detail base class and add the last-modified behavior there.

✅ c5c3a0f

[codecov-commenter]

Codecov Report

Merging #669 (7e57d3f) into develop (b0ff08f) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #669      +/-   ##
===========================================
+ Coverage    98.64%   98.74%   +0.10%     
===========================================
  Files          121      121              
  Lines         5677     6159     +482     
===========================================
+ Hits          5600     6082     +482     
  Misses          77       77              

[rlskoeser]

sorry if I was unclear: we need the item type filter on the search view. (I wasn't thinking about adding it here: it may not strictly be necessary here, but it's probably a good idea)

[kmcelwee]

oh whoops, yeah, here it is 7e57d3f