-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve VS Code Dark Plus theme accuracy #103
Conversation
See the following resources for a detailed overview of the changes: Repo: https://github.com/karlhorky/prismjs-vs-code-dark-theme-fix Website: https://objective-williams-02e373.netlify.app/
That looks really good! Could you please run the Also, you might be interested to know that Prism also has a regex language that will add itself to JS, JSX, TS, and TSX. I gave it some highlighting a while ago but it's far from ideal. Also also, should I add an alias for control-flow keywords (e.g. |
That would be great, cheers! This along with PrismJS/prism#2528 would probably cover a lot of the remaining missing things.
Added to the demo, thanks! I also added a new escape token color.
Sure, done! |
Also styled the |
Original issue: PrismJS/prism#2528 Pull request: PrismJS/prism#2533
@RunDevelopment Added the color changes from I guess this PR is now ready to go? |
Thank you for contributing @karlhorky! |
Glad to help! Thanks for the merge and your tireless work on this!! 💯 |
@RunDevelopment would it be possible to get a new version published to npm with these changes? Version |
@mAAdhaTTah Could you please handle the release? The next version will be |
@RunDevelopment @karlhorky done. |
Thanks @RunDevelopment @mAAdhaTTah ! |
Hi, a quick fix for a number of color inaccuracies in the VS Code Dark Plus theme.
Try out the theme switcher dropdown on the website below for a detailed overview of the changes:
Website: https://objective-williams-02e373.netlify.app/
Repo: https://github.com/karlhorky/prismjs-vs-code-dark-theme-fix
Preview (may be outdated):
Old
New