-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS Extras: Highlight import and export bindings #2533
JS Extras: Highlight import and export bindings #2533
Conversation
LGTM, thanks! |
Original issue: PrismJS/prism#2528 Pull request: PrismJS/prism#2533
|
I think that's not new - looks like it was added in #1743 |
Yes, it's been there for a while. The idea is that class names are usually written in pascal case, so we can use this naming convention. However, it's not perfect, so I didn't want to name it "class-name". |
Thanks for the clarification! |
@RunDevelopment @mAAdhaTTah could we have this also published as a new version of Version |
Well, it's been 2 months since the last release. @mAAdhaTTah I'll prepare the changelog. |
@karlhorky @RunDevelopment v1.22.0 has been published. |
@mAAdhaTTah Thanks! On that note: Should we include all changes in the GH release notes? I always removed/didn't include them because I don't want to maintain two copies of the same thing. How do we want to handle this going forward? Always/never include the changes or just have a link to our changelog in the release notes? |
@RunDevelopment That makes sense, just do it in the Changelog. |
Cool, thanks for that! |
This wraps the binding declarations of import/export statements.
@karlhorky
This should also work for you, right?