Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show invisibles does not show invisibles inside of tokens #1608

Closed
RunDevelopment opened this issue Nov 12, 2018 · 0 comments · Fixed by #1610
Closed

Show invisibles does not show invisibles inside of tokens #1608

RunDevelopment opened this issue Nov 12, 2018 · 0 comments · Fixed by #1610

Comments

@RunDevelopment
Copy link
Member

RunDevelopment commented Nov 12, 2018

Invisible characters within tokens (such as comments, strings, CSS selectors, etc.) are not displayed.

image

More examples

mAAdhaTTah pushed a commit that referenced this issue Jan 23, 2019
This PR fixes #1608.

The patterns for invisible characters (ICs) are now also recursively added to the `inside` of every pattern.

I also had to change the color of ICs because in #1607 I changed the color to `inherit` which causes the ICs to have different colors depending on which token they are inside of.
So, to make everything consistent, I changed the color to grey (`rgb(128, 128, 128)`) and made it half transparent so it would blend in. Looks really similar to #1607.

---

Most of the code is just traversing the language definition, handling the different kinds of tokens (simple regex, array, pattern object), and trying not to fall because of the added tokens for ICs and the `rest` property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant