-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown: Added support for code blocks #1562
Merged
mAAdhaTTah
merged 12 commits into
PrismJS:master
from
RunDevelopment:markdown-code-blocks
Dec 1, 2018
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9f40265
Added support for markdown code blocks
RunDevelopment 9268808
Added syntax highlighting of code blocks
RunDevelopment f8055cf
Fixed decoding issue
RunDevelopment 745c213
Minor improvements
RunDevelopment 2d622f1
Show invisibles inside tokens
RunDevelopment 7a2d153
Revert "Show invisibles inside tokens"
RunDevelopment 24ad1df
Merge remote-tracking branch 'upstream/master'
RunDevelopment 2103363
Merge remote-tracking branch 'upstream/master'
RunDevelopment 5ded688
Merge remote-tracking branch 'upstream/master'
RunDevelopment 59f841e
Merge remote-tracking branch 'upstream/master'
RunDevelopment abd1990
Resolved merge conflict
RunDevelopment f4430cc
Stylistic changes
RunDevelopment File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what our style policy is on this, but I generally prefer
{}
aroundif
blocks like this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks like core uses
{}
withif
blocks. Otherwise, code looks good. Love this improvement.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right!