Set type="button" attribute for copy to clipboard plugin. #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. Thanks for the contribution! |
|
🙌 @mAAdhaTTah is a new release planned anytime soon? |
|
@mAAdhaTTah I think a new release after #2584 might be a good idea. I'm waiting for a confirmation from @yetingli that all vulnerabilities have been fixed but I'm reasonably confident that there won't be many others because of #2590. |
|
@RunDevelopment I'm on board with that. We did a release recently, so maybe next one should be a patch? |
|
@mAAdhaTTah Yeah. All commits since v1.22.0 were enhancements and bug fixes, so I agree that it should be a patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
When using Prism + copy to clipboard inside a HTML form, the form is submitted when copying.
It's because by default the button is seen as a submit button.
Adding the
type="button"attribute prevents this.