Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix INI #2779

Merged
merged 3 commits into from
Mar 2, 2021
Merged

Fix INI #2779

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 38 additions & 7 deletions components/prism-ini.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,42 @@
Prism.languages.ini= {
'comment': /^[ \t]*[;#].*$/m,
'selector': /^[ \t]*\[.*?\]/m,
'constant': /^[ \t]*[^\s=]+?(?=[ \t]*=)/m,
'attr-value': {
pattern: /=.*/,

/**
* The component mimics the behavior of the Win32 API parser.
*
* @see {@link https://github.com/PrismJS/prism/issues/2775#issuecomment-787477723}
*/

'comment': {
pattern: /(^[ \f\t\v]*)[#;][^\n\r]*/m,
lookbehind: true
},
'header': {
pattern: /(^[ \f\t\v]*)\[[^\n\r\]]*\]?/m,
RunDevelopment marked this conversation as resolved.
Show resolved Hide resolved
lookbehind: true,
inside: {
'punctuation': /^[=]/
'section-name': {
pattern: /(^\[[ \f\t\v]*)[^ \f\t\v\]]+(?:[ \f\t\v]+[^ \f\t\v\]]+)*/,
lookbehind: true,
alias: 'selector'
},
'punctuation': /\[|\]/
}
}
},
'key': {
pattern: /(^[ \f\t\v]*)[^ \f\n\r\t\v=]+(?:[ \f\t\v]+[^ \f\n\r\t\v=]+)*(?=[ \f\t\v]*=)/m,
lookbehind: true,
alias: 'attr-name'
},
'value': {
pattern: /(=[ \f\t\v]*)[^ \f\n\r\t\v]+(?:[ \f\t\v]+[^ \f\n\r\t\v]+)*/,
lookbehind: true,
alias: 'attr-value',
inside: {
'inner-value': {
pattern: /^("|').+(?=\1$)/,
lookbehind: true
}
}
},
'punctuation': /=/
};
2 changes: 1 addition & 1 deletion components/prism-ini.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

65 changes: 50 additions & 15 deletions tests/languages/ini/comment_feature.test
Original file line number Diff line number Diff line change
@@ -1,15 +1,50 @@
;
; foobar
# foobar

----------------------------------------------------

[
["comment", ";"],
["comment", "; foobar"],
["comment", "# foobar"]
]

----------------------------------------------------

Checks for comments.
#
;
#
;
#
#
#
#;
#[foo]
#foo=bar
#foobar
;
;
;
;#
;[foo]
;foo=bar
;foobar
foo#bar
foobar#
foo;bar
foobar;

----------------------------------------------------

[
["comment", "#"],
["comment", ";"],
["comment", "#"],
["comment", ";"],
["comment", "#"],
["comment", "#\t"],
["comment", "# "],
["comment", "#;"],
["comment", "#[foo]"],
["comment", "#foo=bar"],
["comment", "#foobar"],
["comment", ";"],
["comment", ";\t"],
["comment", "; "],
["comment", ";#"],
["comment", ";[foo]"],
["comment", ";foo=bar"],
["comment", ";foobar"],
"\nfoo#bar\nfoobar#\nfoo;bar\nfoobar;"
]

----------------------------------------------------

Checks for comments.
86 changes: 86 additions & 0 deletions tests/languages/ini/header_feature.test
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
[foo1]
[ "foo2" ]
[ foo3 ]
[" foo4 "]
["foo5 bar5"]
["foo6"]
[foo7
[foo8 bar8]
[foo9[bar9]
[foo10]
[foo11]bar11]

----------------------------------------------------

[
["header", [
["punctuation", "["],
["section-name", "foo1"],
["punctuation", "]"]
]],

["header", [
["punctuation", "["],
["section-name", "\"foo2\""],
["punctuation", "]"]
]],

["header", [
["punctuation", "["],
["section-name", "foo3"],
["punctuation", "]"]
]],

["header", [
["punctuation", "["],
["section-name", "\" foo4 \""],
["punctuation", "]"]
]],

["header", [
["punctuation", "["],
["section-name", "\"foo5 bar5\""],
["punctuation", "]"]
]],

["header", [
["punctuation", "["],
["section-name", "\"foo6\""],
["punctuation", "]"]
]],

["header", [
["punctuation", "["],
["section-name", "foo7"]
]],

["header", [
["punctuation", "["],
["section-name", "foo8 bar8"],
["punctuation", "]"]
]],

["header", [
["punctuation", "["],
["section-name", "foo9[bar9"],
["punctuation", "]"]
]],

["header", [
["punctuation", "["],
["section-name", "foo10"],
["punctuation", "]"]
]],

["header", [
["punctuation", "["],
["section-name", "foo11"],
["punctuation", "]"]
]],

"bar11]"
]

----------------------------------------------------

Checks for headers (and section names).
90 changes: 69 additions & 21 deletions tests/languages/ini/key_value_feature.test
Original file line number Diff line number Diff line change
@@ -1,21 +1,69 @@
foo=Bar Baz
foobar=42

----------------------------------------------------

[
["constant", "foo"],
["attr-value", [
["punctuation", "="],
"Bar Baz"
]],
["constant", "foobar"],
["attr-value", [
["punctuation", "="],
"42"
]]
]

----------------------------------------------------

Checks for key/value pairs.
bar1 =
"bar2" =
'bar3' =
bar4 =
" bar5 "=
"bar6"=
' bar7 '=
'bar8'=
= baz9
= "baz10"
= 'baz11'
= baz12
=" baz13 "
="b14"a14"z14"
="baz15"
="baz16
=' baz17 '
='baz18'
=b19"a19"z19
=b20"az20
=ba21"z21
=baz22
=baz23"
bar24
bar25 baz25=qux25
bar26=
bar27==baz27
bar28=baz28
bar29=baz29 qux29
bar30=baz30=qux30

----------------------------------------------------

[
["key", "bar1"], ["punctuation", "="],
["key", "\"bar2\""], ["punctuation", "="],
["key", "'bar3'"], ["punctuation", "="],
["key", "bar4"], ["punctuation", "="],
["key", "\" bar5 \""], ["punctuation", "="],
["key", "\"bar6\""], ["punctuation", "="],
["key", "' bar7 '"], ["punctuation", "="],
["key", "'bar8'"], ["punctuation", "="],
["punctuation", "="], ["value", ["baz9"]],
["punctuation", "="], ["value", ["\"", ["inner-value", "baz10"], "\""]],
["punctuation", "="], ["value", ["'", ["inner-value", "baz11"], "'"]],
["punctuation", "="], ["value", ["baz12"]],
["punctuation", "="], ["value", ["\"", ["inner-value", " baz13 "], "\""]],
["punctuation", "="], ["value", ["\"", ["inner-value", "b14\"a14\"z14"], "\""]],
["punctuation", "="], ["value", ["\"", ["inner-value", "baz15"], "\""]],
["punctuation", "="], ["value", ["\"baz16"]],
["punctuation", "="], ["value", ["'", ["inner-value", " baz17 "], "'"]],
["punctuation", "="], ["value", ["'", ["inner-value", "baz18"], "'"]],
["punctuation", "="], ["value", ["b19\"a19\"z19"]],
["punctuation", "="], ["value", ["b20\"az20"]],
["punctuation", "="], ["value", ["ba21\"z21"]],
["punctuation", "="], ["value", ["baz22"]],
["punctuation", "="], ["value", ["baz23\""]],
"\nbar24\n",
["key", "bar25 baz25"], ["punctuation", "="], ["value", ["qux25"]],
["key", "bar26"], ["punctuation", "="],
["key", "bar27"], ["punctuation", "="], ["value", ["=baz27"]],
["key", "bar28"], ["punctuation", "="], ["value", ["baz28"]],
["key", "bar29"], ["punctuation", "="], ["value", ["baz29 qux29"]],
["key", "bar30"], ["punctuation", "="], ["value", ["baz30=qux30"]]
]

----------------------------------------------------

Checks for key-value pairs.
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
[owner]
[foobar]

----------------------------------------------------

[
["selector", "[owner]"],
["selector", "[foobar]"]
]

----------------------------------------------------

Checks for section titles.
=

----------------------------------------------------

[
["punctuation", "="]
]

----------------------------------------------------

Checks for punctuation marks.