Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: Use cache #2959

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Conversation

RunDevelopment
Copy link
Member

ESLint has a caching functionality. Might as well use it since linting got slower after #2951.

@github-actions
Copy link

No JS Changes

Generated by 🚫 dangerJS against 8770269

@mAAdhaTTah
Copy link
Member

Should we save + restore the cache in CI?

@RunDevelopment
Copy link
Member Author

Nah, I don't want people to suddenly have to commit the ESLint cache as well.

Plus, the cache might be outdated or otherwise invalid (the cache assumes that ESLint rules + config are constant) so it's actually good that the CI doesn't use the cache.

@mAAdhaTTah
Copy link
Member

They wouldn't have to commit the cache, same way they don't have to commit the npm cache, but if the eslint cache is assuming things about the rules, then yeah, let's leave it.

@RunDevelopment RunDevelopment merged commit b4ac061 into PrismJS:master Jun 21, 2021
@RunDevelopment RunDevelopment deleted the eslint-cache branch June 21, 2021 18:14
RunDevelopment added a commit to RunDevelopment/prism that referenced this pull request Jun 27, 2021
The ESLint cache file from PrismJS#2959 and the JSDoc config file were added.
RunDevelopment added a commit to RunDevelopment/prism that referenced this pull request Jun 27, 2021
The ESLint cache file from PrismJS#2959 and the JSDoc config file were added.
RunDevelopment added a commit that referenced this pull request Jun 27, 2021
The ESLint cache file from #2959 and the JSDoc config file were added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants