Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass: Fixed issues with CSS Extras #2994

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

RunDevelopment
Copy link
Member

This fixes #2992.

Sass did not expect CSS to be modified by CSS Extras. Sass 1) did not have an optional dependency for css-extras and it did not declare its tokens as greedy: true. Both of these issues have been fixed. I also improved the boundary checks of some CSS Extras tokens to make sure they can't be part of other identifiers.

@github-actions
Copy link

JS File Size Changes (gzipped)

A total of 2 files have changed, with a combined diff of +18 B (+0.9%).

file master pull size diff % diff
components/prism-css-extras.min.js 1.45 KB 1.46 KB +12 B +0.8%
components/prism-sass.min.js 451 B 457 B +6 B +1.3%

Generated by 🚫 dangerJS against b961059

Copy link
Collaborator

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass class selectors use inline-color plugin
2 participants