Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OCaml #628

Merged
merged 4 commits into from
Sep 9, 2015
Merged

Add support for OCaml #628

merged 4 commits into from
Sep 9, 2015

Conversation

Golmote
Copy link
Contributor

@Golmote Golmote commented Jul 6, 2015

Examples:

prism-ocaml

@LeaVerou
Copy link
Member

LeaVerou commented Jul 7, 2015

Nice work!
I’m not quite sure about the aliases; is there any semantic meaning in them, or are they purely to get highlighting for the current themes?

@Golmote
Copy link
Contributor Author

Golmote commented Jul 7, 2015

I'd say that the directives aliased as functions have some meaning.
But I must admit the type token aliased as variable is purely for visual purpose... I kinda thought that's what aliases were for.

@Golmote
Copy link
Contributor Author

Golmote commented Jul 7, 2015

The builtin alias could be the easy alternative (as it does not mean much by itself...), but this is just bypassing the problem, isn't it?

Golmote added a commit that referenced this pull request Sep 9, 2015
@Golmote
Merge pull request #628 from Golmote/prism-ocaml
556c04d 
Add support for OCaml
@Golmote Golmote merged commit 556c04d into PrismJS:gh-pages Sep 9, 2015
@Golmote Golmote deleted the prism-ocaml branch September 9, 2015 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Golmote @LeaVerou