Ensure show-invisibles compat with autoloader #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the autoloader, the language isn't loaded at the time the show-invisibles plugin attaches its extra tokens. This defers attaching the extra tokens to just before highlighting, so we ensure we're able to attach to the language grammar.
mAAdhaTTah
added a commit
to intraxia/wp-gistpen
that referenced
this pull request
Jan 30, 2016
The show invisibles plugin needs to be handled differently. A PR is open upstream to resolve this issue: PrismJS/prism#874
mAAdhaTTah
added a commit
to intraxia/wp-gistpen
that referenced
this pull request
Jan 30, 2016
The show invisibles plugin needs to be handled differently. A PR is open upstream to resolve this issue: PrismJS/prism#874 Fixes #49
|
Your solution is correct. In the future we should add some kind of |
zeitgeist87
added a commit
that referenced
this pull request
Feb 1, 2016
Ensure show-invisibles compat with autoloader
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the autoloader, the language isn't loaded
at the time the show-invisibles plugin attaches its
extra tokens. This defers attaching the extra tokens
to just before highlighting, so we ensure we're able
to attach to the language grammar.