Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace homepage screenshots #208

Merged
merged 5 commits into from
Dec 28, 2022
Merged

Replace homepage screenshots #208

merged 5 commits into from
Dec 28, 2022

Conversation

AshtakaOOf
Copy link
Contributor

@AshtakaOOf AshtakaOOf commented Dec 26, 2022 •
edited
Loading

Update screenshots to 6.1, straightforward enough.
Also remove Customize Dark and Light and replace with only one screenshot with Fluent.
I hope I didn't break anything, because if I did I'm gonna cry.

@AshtakaOOf
Replace index screenshots
8da4d58 
Update screenshots to 6.1
Also remove Customize Dark and Light with only one screenshot with Fluent

Signed-off-by: Adrien <66513643+AshtakaOOf@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Dec 26, 2022 •
edited
Loading

✅ Deploy Preview for prismlauncher ready!

Name Link
🔨 Latest commit adcba23
🔍 Latest deploy log https://app.netlify.com/sites/prismlauncher/deploys/63ab358d1094be0009b4e4d4
😎 Deploy Preview https://deploy-preview-208--prismlauncher.netlify.app/404
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@AshtakaOOf
Copy link
Contributor Author

Yeah I broke something sadly

@AshtakaOOf
Add dropshadow
d2eb19d 
And fix customize

Signed-off-by: Adrien <66513643+AshtakaOOf@users.noreply.github.com>
@flowln
Copy link
Contributor

flowln commented Dec 26, 2022

The update mods screenshots are not from the update mods thingy, they're from the mod downloader confirmation dialog :p

@AshtakaOOf
Copy link
Contributor Author

AAAAAAh

@AshtakaOOf
Fix ModUpdate
09c11fb 
I'm dumb lmao

Signed-off-by: Adrien <66513643+AshtakaOOf@users.noreply.github.com>
@AshtakaOOf
Copy link
Contributor Author

Flow flow I fixed it!

flowln
flowln approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job
pats Ashtaka

i'll not merge this rn since i remember that we have had issues with the image dimensions on Flatpak because of something to do with those images. I'll wait until someone with more knowledge about it takes a look at this

@DioEgizio
Copy link
Member

Can you add a modpack updating screenshot?
. this hyperlink broke btw

@DioEgizio
Copy link
Member

good job pats Ashtaka

i'll not merge this rn since i remember that we have had issues with the image dimensions on Flatpak because of something to do with those images. I'll wait until someone with more knowledge about it takes a look at this

as #196 says, you have to edit that file in the prism repo too

Scrumplex
Scrumplex reviewed Dec 26, 2022
View reviewed changes
src/index.md Outdated Show resolved Hide resolved
@TheKodeToad
Copy link
Member

Do the dark theme screenshots need to be duplicated?

@DioEgizio
Copy link
Member

Why?

@AshtakaOOf
Copy link
Contributor Author

I'm doing the modpack updating thing @DioEgizio

@AshtakaOOf
Add ModpackUpdate
7a88ebc 
Also do the scrumplex review thing and fix the hyperlink

Signed-off-by: Adrien <66513643+AshtakaOOf@users.noreply.github.com>
@AshtakaOOf AshtakaOOf mentioned this pull request Dec 26, 2022
Merged
@TheKodeToad
Copy link
Member

TheKodeToad commented Dec 26, 2022 •
edited
Loading

Why?

I mean they are duplicated.

image

@AshtakaOOf
Copy link
Contributor Author

AshtakaOOf commented Dec 26, 2022 •
edited
Loading

There are no cool light mode theme :(
And I couldn't figure out how to have only one file...

@TheKodeToad
Copy link
Member

There are no cool light mode theme :( And I couldn't figure out how to have only one file...

Ah, gotcha. Maybe it would be more convenient to find a way to not show the version.

Scrumplex
Scrumplex reviewed Dec 27, 2022
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was src/img/Rory_11.png added? :O

@AshtakaOOf
Copy link
Contributor Author

Because the multimc cat is also in the files :)

@DioEgizio
Copy link
Member

Because the multimc cat is also in the files :)

Look at the 404 page to see why

@AshtakaOOf
Copy link
Contributor Author

I know should I replace it with Rory?

@AshtakaOOf
Rory is new 404 cat now
adcba23 
:3

Signed-off-by: Adrien <66513643+AshtakaOOf@users.noreply.github.com>
@AshtakaOOf AshtakaOOf requested a review from Scrumplex December 28, 2022 02:43
@Scrumplex Scrumplex merged commit e3879ea into PrismLauncher:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowln flowln flowln approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

@DioEgizio DioEgizio DioEgizio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AshtakaOOf @flowln @DioEgizio @TheKodeToad @Scrumplex