Skip to content

Commit

Permalink
Merge pull request #2542 from jeromelaban/dev/jela/winui-0-8-packaging
Browse files Browse the repository at this point in the history
fix: Adjust net5.0 targetframework to fix assets packaging
  • Loading branch information
brianlagunas authored Sep 10, 2021
2 parents 883f964 + ef1fd04 commit 8cb580d
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions e2e/Uno/ModuleA/ModuleA.WinUI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project Sdk="MSBuild.Sdk.Extras">
<PropertyGroup>
<TargetFrameworks>netstandard2.0;xamarinios10;MonoAndroid10.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net5.0-windows10.0.18362.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net5.0-windows10.0.18362</TargetFrameworks>
<!-- Ensures the .xr.xml files are generated in a proper layout folder -->
<GenerateLibraryLayout>true</GenerateLibraryLayout>
<DefineConstants>$(DefineConstants);HAS_WINUI</DefineConstants>
Expand All @@ -14,7 +14,7 @@
<ItemGroup Condition="$(TargetFramework.StartsWith('xamarinios')) or $(TargetFramework.StartsWith('xamarinmac')) or $(TargetFramework.StartsWith('MonoAndroid')) or $(TargetFramework.StartsWith('netstandard'))">
<PackageReference Include="Uno.WinUI" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)'!='net5.0-windows10.0.18362.0'">
<ItemGroup Condition="'$(TargetFramework)'!='net5.0-windows10.0.18362'">
<Page Include="**\*.xaml" Exclude="bin\**\*.xaml;obj\**\*.xaml" />
<Compile Update="**\*.xaml.cs">
<DependentUpon>%(Filename)</DependentUpon>
Expand All @@ -28,4 +28,4 @@
<ProjectReference Include="..\..\..\src\Uno\Prism.DryIoc.Uno\Prism.DryIoc.Uno.WinUI.csproj" />
<ProjectReference Include="..\..\..\src\Uno\Prism.Uno\Prism.Uno.WinUI.csproj" />
</ItemGroup>
</Project>
</Project>
2 changes: 1 addition & 1 deletion src/Uno/Prism.DryIoc.Uno/Prism.DryIoc.Uno.WinUI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project Sdk="MSBuild.Sdk.Extras">
<PropertyGroup>
<TargetFrameworks>netstandard2.0;xamarinios10;MonoAndroid10.0;xamarinmac20</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net5.0-windows10.0.18362.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net5.0-windows10.0.18362</TargetFrameworks>
<NoWarn>$(NoWarn);1591</NoWarn>
<AssemblyName>Prism.DryIoc.Uno</AssemblyName>
<PackageId>Prism.DryIoc.Uno.WinUI</PackageId>
Expand Down
2 changes: 1 addition & 1 deletion src/Uno/Prism.Unity.Uno/Prism.Unity.Uno.WinUI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project Sdk="MSBuild.Sdk.Extras">
<PropertyGroup>
<TargetFrameworks>netstandard2.0;xamarinios10;MonoAndroid10.0;xamarinmac20</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net5.0-windows10.0.18362.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net5.0-windows10.0.18362</TargetFrameworks>
<DefineConstants>$(DefineConstants);HAS_WINUI</DefineConstants>
<AssemblyName>Prism.Unity.Uno</AssemblyName>
<RootNamespace>Prism.Unity</RootNamespace>
Expand Down
6 changes: 3 additions & 3 deletions src/Uno/Prism.Uno/Prism.Uno.WinUI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project Sdk="MSBuild.Sdk.Extras">
<PropertyGroup>
<TargetFrameworks>netstandard2.0;xamarinios10;MonoAndroid10.0;xamarinmac20</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net5.0-windows10.0.18362.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net5.0-windows10.0.18362</TargetFrameworks>
<GenerateLibraryLayout>true</GenerateLibraryLayout>
<AssemblyName>Prism.Uno</AssemblyName>
<RootNamespace>Prism</RootNamespace>
Expand All @@ -26,10 +26,10 @@
<PackageReference Include="Uno.Core" />
<PackageReference Include="Uno.Microsoft.Xaml.Behaviors.WinUI.Managed" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)'=='net5.0-windows10.0.18362.0'">
<ItemGroup Condition="'$(TargetFramework)'=='net5.0-windows10.0.18362'">
<PackageReference Include="Microsoft.Xaml.Behaviors.WinUI.Managed" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)'!='net5.0-windows10.0.18362.0'">
<ItemGroup Condition="'$(TargetFramework)'!='net5.0-windows10.0.18362'">
<Page Include="**\*.xaml"
Exclude="bin\**\*.xaml;obj\**\*.xaml" />
<Compile Update="**\*.xaml.cs">
Expand Down

0 comments on commit 8cb580d

Please sign in to comment.