Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Housekeeping] Add tests around AutoRegisterForNavigation #2088

Closed
dansiegel opened this issue Apr 23, 2020 · 2 comments · Fixed by #2089
Closed

[Housekeeping] Add tests around AutoRegisterForNavigation #2088

dansiegel opened this issue Apr 23, 2020 · 2 comments · Fixed by #2089
Labels
bug housekeeping XF

Comments

@dansiegel
Copy link
Member

Description

We are currently missing tests around AutoRegisterForNavigation. There are a few things that need to be done..

  1. Ensure that normal/default registration occurs
  2. Test the method we use to customize the registration name
  3. Validate that Xamarin.Forms.TabbedPage and Xamarin.Forms.NavigationPage are both registered for Navigation.
dansiegel added a commit that referenced this issue Apr 23, 2020
@dansiegel
adding tests for AutoRegisterForNavigation - fixes #2088
d56b4f3
@dansiegel dansiegel mentioned this issue Apr 23, 2020
Merged
3 tasks
dansiegel added a commit that referenced this issue Apr 23, 2020
@dansiegel
adding tests for AutoRegisterForNavigation - fixes #2088
695b242
@dansiegel dansiegel added the bug label Apr 23, 2020
@dansiegel
Copy link
Member Author

As expected some suspected bugs were uncovered in tests around the proper wiring up of the NavigationPage, TabbedPage and customization of the registration names

dansiegel added a commit that referenced this issue Apr 23, 2020
@dansiegel
adding tests for AutoRegisterForNavigation - fixes #2088
402b0f6
dansiegel added a commit that referenced this issue Apr 24, 2020
@dansiegel
adding tests for AutoRegisterForNavigation - fixes #2088
9bdc2ea
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug housekeeping XF
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds Tests and fixes issues with AutoRegistrationForNavigation PrismLibrary/Prism
1 participant
@dansiegel