Region Support for Xamarin.Forms #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
added
enhancement
XF
DO-NOT-MERGE-!!! 🛑
dansiegel
force-pushed
the
wip-regions
branch
4 times, most recently
from
7fe506f
to
90cdd78
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Out of Box adapters to support:
Unsupported Controls:
Development Note: The CollectionView Region Adapter is still part of this PR, however it has not been added to the RegionAdapterMappings due to the issues mentioned above. Once the issues have been resolved a follow up PR will add the support for CollectionView. |
dansiegel
removed
the
DO-NOT-MERGE-!!! 🛑
brianlagunas
approved these changes
Aug 20, 2020
| /// </summary> | ||
| /// <typeparam name="TView">The Type of <see cref="View"/> to register</typeparam> | ||
| /// <param name="containerRegistry"><see cref="IContainerRegistry"/> used to register type for Navigation.</param> | ||
| /// <param name="name">The unique name to register with the Page</param> |
| /// <typeparam name="TView">The Type of <see cref="View"/> to register</typeparam> | ||
| /// <param name="containerRegistry"><see cref="IContainerRegistry"/> used to register type for Navigation.</param> | ||
| /// <param name="name">The unique name to register with the Page</param> | ||
| public static void RegisterForNavigation<TView>(this IContainerRegistry containerRegistry, string name = null) |
There was a problem hiding this comment.
rename to RegisterForRegionNavigation
| /// </summary> | ||
| /// <returns>A new instance of <see cref="AllActiveRegion"/>.</returns> | ||
| protected override IRegion CreateRegion() => | ||
| new AllActiveRegion(); |
| throw new InvalidOperationException(Resources.LayoutViewHasChildrenException); | ||
| } | ||
|
|
||
| BindableLayout.SetItemsSource(regionTarget, region.ActiveViews); |
| /// </summary> | ||
| /// <returns>A new instance of <see cref="AllActiveRegion"/>.</returns> | ||
| protected override IRegion CreateRegion() => | ||
| new AllActiveRegion(); |
| /// </summary> | ||
| /// <returns>A new instance of <see cref="SingleActiveRegion"/>.</returns> | ||
| protected override IRegion CreateRegion() => | ||
| new SingleActiveRegion(); |
| SynchronizeRegionContext(); | ||
|
|
||
| // Now register for events to keep them in sync | ||
| HostControlRegionContext.PropertyChanged += RegionContextObservableObject_PropertyChanged; |
There was a problem hiding this comment.
let's look into this for memory leaks
This was referenced Aug 20, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Yep we're closing Prism's OLDEST open issue.... Support for Regions in Xamarin.Forms!
Bugs Fixed
API Changes
Too much to list... Suffice it to say we've taken Regions from Prism.Wpf and made some slight modifications for Xamarin.Forms.
Behavioral Changes
This changes Prism.DryIoc.Wpf & Prism.Unity.Wpf to no longer register their exceptions in the Bootstrapper/PrismApplication as this will now simply be done in the ContainerExtension instead...
PR Checklist