Add support for WinUI 3 #2393
Merged
Add support for WinUI 3 #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
force-pushed
the
dev/jela/winui
branch
7 times, most recently
from
b00c0d1
to
cc3e8b2
Compare
jeromelaban
force-pushed
the
dev/jela/winui
branch
from
cc3e8b2
to
43e5f7d
Compare
jeromelaban
commented
Apr 23, 2021
| @@ -79,6 +104,18 @@ jobs: | |||
| vmImage: $(MacImage) | |||
| workspace: | |||
| clean: all | |||
|
|
|||
| variables: | |||
| disable_package_restore_step: true | |||
There was a problem hiding this comment.
This is required to ensure the package resolution logic matches the build. I think it should be done for all targets (dotnet build does this now anyways).
There was a problem hiding this comment.
The original intent of the separate process was to be able to more clearly look in the logs for package restoration issues vs build issues... however with how unreliable the NuGet task can be at times I'm not opposed to normalizing on having msbuild / dotnet cli handling the restore for us
dansiegel
approved these changes
Apr 23, 2021
jeromelaban
force-pushed
the
dev/jela/winui
branch
from
43e5f7d
to
b0a07ab
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds support for WinUI 3 (Prism.Uno.WinUI and associated)
API Changes
None.
Behavioral Changes
PR Checklist