Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Target Element BindingContext instead of the Page VM #2404

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

dansiegel
Copy link
Member

@dansiegel dansiegel commented Apr 20, 2021

Description of Change

Fixes bug with the Binding Context of the ParentPageAwareExtension base XAML Extension setting the BindingContext to the Parent Page's Binding Context instead of the Target Element's Binding Context.

Bugs Fixed

API Changes

Adds TargetBindingContext enum. To use the legacy behavior of targeting the Page's BindingContext simply set this property. By default it will use the TargetElement.

Behavioral Changes

Navigation XAML Extensions & Dialog XAML Extension now correctly set the BindingContext of the Command / Extension to the Target Element's Binding Context instead of the Page's Binding Context. This correctly supports uses within Lists.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel merged commit a2a50f0 into master Apr 21, 2021
@dansiegel dansiegel deleted the xaml-nav branch April 21, 2021 00:05
@dansiegel dansiegel added this to the Prism 8.1 milestone May 24, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant