Changed the access modifier of the AutowireViewModel method to public #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the MvvmHelpers class.
|
|
|
Should the access modifier for the UWP/WinUI method be changed to public as well? |
|
Might as well, so the API is consistent across platforms. |
…WP/WinUI method from internal to public.
dansiegel
requested changes
Sep 10, 2021
There was a problem hiding this comment.
While I'm fine with the change this should match what we've done for Prism.Forms which is to keep it hidden from Intellisense. It's really an edge case that anyone would need to use it and it isn't something we want people seeing as part of the public API. Be sure to add the following attribute:
[EditorBrowsable(EditorBrowsableState.Never)]…the AutowireViewModel methods in the MvvmHelpers class.
dansiegel
approved these changes
Sep 10, 2021
|
Thanks for the PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changed the access modifier of the AutowireViewModel method from internal to public in the MvvmHelpers class and added documentation.
Bugs Fixed
API Changes
Changed:
Behavioral Changes
Developers can now access this method from an external assembly.
PR Checklist