Ability to select tabs from TabbedPage's TitleView #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Looks good to me. Are you able to add a test for the scenario? We won't be able to merge until we get the build pipelines fixed but this should be fine to get in before we do the next release. |
|
Oh sorry, I'm kinda still not enough familiar with writing tests! 🥲 |
dansiegel
force-pushed
the
navigate-to-tab-inside-tab
branch
from
b5ec4a2
to
e8fb4de
Compare
|
@mhrastegari thanks for the PR I've rebased this on the latest changes and added some unit tests. I would encourage you to take a look so that next time you'll have a better understanding to be able to contribute some tests along the way :) |
|
Sure Dan :) thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In some of our projects we needed to navigate to tabs from the main
TitleViewso we changed a little bit of theTabbedPagecode.Hope it'll be useful for you guys and users too. ❤️