New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DialogService - Setting XamlRoot #2980

Merged

dansiegel merged 2 commits into master from dev/ds/dialog-xaml-root

Oct 11, 2023

Member

dansiegel commented Oct 11, 2023

Description of Change

This fixes an exception encountered in the DialogService on WinUI by setting the XamlRoot.

Caused by Error & crash when showing ContentDialog without XamlRoot microsoft/microsoft-ui-xaml#3678

dansiegel added 2 commits

October 10, 2023 22:03


          fix: setting XamlRoot

df68b81


          chore: catch exceptions to invoke for DialogResult

d2c42f4

dansiegel requested a review from brianlagunas as a code owner

October 11, 2023 04:05

dansiegel added this to the Prism 9.0 milestone

dansiegel merged commit 91ee9b0 into master

3 checks passed

dansiegel deleted the dev/ds/dialog-xaml-root branch

October 11, 2023 12:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet