Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RootPage Title/IconImageSource when parent is TabbedPage #3039

Merged
merged 4 commits into from
Jan 6, 2024

Conversation

dansiegel
Copy link
Member

Description of Change

Adds behavior for NavigationPage to ensure that if the NavigationPage Title/IconImageSource are not set, and the NavigationPage Parent is set to a TabbedPage that we provide a pass through binding to the Root Page.

Bugs Fixed

API Changes

Added:

  • NavigationPageTabbedParentBehavior

Behavioral Changes

New Page Behavior will validate if the NavigationPage does not have a Title/IconImageSource and will provide a pass through binding when the NavigationPage.Parent is a TabbedPage.

@dansiegel dansiegel marked this pull request as ready for review January 4, 2024 13:44
@dansiegel dansiegel added this to the Prism 9.0 milestone Jan 6, 2024
@dansiegel dansiegel added the MAUI label Jan 6, 2024
@dansiegel dansiegel merged commit 9e17d1b into master Jan 6, 2024
3 checks passed
@dansiegel dansiegel deleted the dev/ds/navigation-tabs branch January 6, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tabbed Page doesn't show icons and title when using NavigationPage
1 participant