Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to update QuiltiX graph from in-memory MaterialX document #46

Merged
merged 5 commits into from
Feb 16, 2024

Conversation

kwokcb
Copy link
Contributor

@kwokcb kwokcb commented Nov 24, 2023

Issue

This allows for integrations which create an in-memory MaterialX doc which can be routed to QuiltiX to update it's graph.
Fixes #45

Changes

Split out the file read part of load_graph_from_mx_file into a load_graph_from_mx_doc (load from in memory document). The file handling part would stay in load_graph_from_mx_file which would call load_graph_from_mx_doc.

…n disk.

This allows for integrations which create a doc first to load in.
@RichardFrangenberg
Copy link
Member

Looks good, but then the mx_file_loaded signal makes more sense to be emitted from the load_graph_from_mx_file function. Then the load_graph_from_mx_doc wouldn't require a mx_file_path input attribute.

@kwokcb
Copy link
Contributor Author

kwokcb commented Feb 5, 2024

Thanks for catching this. I've remove the mx_file_path argument from load_graph_from_mx_doc and move the signal to load_graph_from_mx_file.

@RichardFrangenberg RichardFrangenberg merged commit 6c045bf into PrismPipeline:main Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for load in MaterialX documents from memory
2 participants