Add 1.20.2 data #786
Merged
Add 1.20.2 data #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration stage settings packet
…-1 instead of null in recipes.json
jonesdevelopment
added a commit
to jonesdevelopment/sonar
that referenced
this pull request
Nov 4, 2023
jonesdevelopment
added a commit
to jonesdevelopment/sonar
that referenced
this pull request
Nov 4, 2023
* feat: implement block state id from PrismarineJS/minecraft-data#786 * feat: recode dimension nbt codec for JoinGame packet * feat(fallback): recode gravity/block collisions check * fix: remove unnecessary debug message * fix: dynamicSpawnYPosition using a set Y buffer * feat: refactor some verification-related configuration values * fix: forEnumConstant() not saving default config values * fix: remove Geyser characters from valid name regex * feat: apply migration fix for every config string * fix: don't do .toUpperCase() for every string * feat: add more description to some enum config types * fix: move "recommended" to listing in comment * fix: remove mc association before queuing the connection * refactor: closed -> knownDisconnect * fix: incompatibility with latest BungeeCord * refactor: fallbackPlayer -> user * fix: BungeeCord kick message serialization not working
|
/makerelease |
Merged
|
Ah wow this included the protocol, didn't see. We'll need some much more extensive review for protocol.json Will look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the 1.20.2 data
I updated the packets using wiki.vg as a guide.
I used minecraft-data-generator-server to generate most of the other data, I had to fix the recipes it outputted since it used -1 instead of null.
I used mc-data-command-generator to generate the commands.json.
I updated the mapIcons.json by just checking the code for the names of each new icon.
And that's about it.
Hopefully everything looks good. We will need to eventually grab a fresh login packet for the loginPacket.json since there was login packet changes, but that sort of requires using minecraft-protocol.