Fix client sending chat_session_update when local UUID does not match UUID on server #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to an offline mode server behind an online mode proxy, the client will send a chat_session_update packet. On faulty (arguable) proxy implementations (e.g. Velocity), this packet will be forwarded to the backend server despite the backend being in offline mode. This will cause a signature mismatch on the server (because the offline mode UUID does not match the UUID we are signing with).
Possible fixes are:
This PR implements fix 2, which mimics the behaviour of the Vanilla client.
Closes #1236