Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip events that ended in the past #16

Open
ProLoser opened this issue Dec 7, 2024 · 0 comments · May be fixed by #17
Open

Skip events that ended in the past #16

ProLoser opened this issue Dec 7, 2024 · 0 comments · May be fixed by #17

Comments

@ProLoser
Copy link
Owner

ProLoser commented Dec 7, 2024

If an event has ended already, we should skip the event after the data loads so that it is not rendered on the map
ProLoser added a commit that referenced this issue Dec 7, 2024
@ProLoser
Skip events that ended in the past
57bd3d9 
Fixes #16

Skip events that have ended before rendering them on the map.

* Add logic in `map.js` to check if an event has ended before rendering it on the map.
* Update the `filter` function in `map.js` to include logic to check if an event has ended before rendering it on the map.
* Add a method to the `Events` class in `map.js` to filter out past events based on their end time.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/ProLoser/funcheapmap/issues/16?shareId=XXXX-XXXX-XXXX-XXXX).
@ProLoser ProLoser linked a pull request Dec 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip events that ended in the past ProLoser/funcheapmap
1 participant
@ProLoser