Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature help #21

Merged
merged 11 commits into from
Feb 12, 2024
Merged

Add signature help #21

merged 11 commits into from
Feb 12, 2024

Conversation

famoser
Copy link
Member

@famoser famoser commented Feb 11, 2024

Adds signature help, but not quite ready:

  • Disable signature help on definition, as leads to crash if new parameter is added
  • Investigate whether can handle macro define/extend better
  • Check definition really shows up in file with complex constructs (e.g. wrapped calls)
  • Possibly find better solution to handle backspace to re-enable caching

@famoser
Copy link
Member Author

famoser commented Feb 12, 2024

Unresolved points:

  • Unclear what target behavior of macros should be at the moment => Leave as is, taking over go to definition behavior
  • Discovery is fast, even in bigger files. No easy way to support backspace => Leave caching disabled as it is now

@famoser famoser merged commit 190f212 into main Feb 12, 2024
2 checks passed
@famoser famoser deleted the improve-symbol-table branch February 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant