Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No 'install' target #23

Closed
joaocandre opened this issue Nov 17, 2021 · 3 comments
Closed

No 'install' target #23

joaocandre opened this issue Nov 17, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@joaocandre
Copy link

joaocandre commented Nov 17, 2021

When compiling cv-plot (without conan), there is no install routine configured in the cmake files. Since there is a CMAKE_INSTALL_PREFIX macro, shouldn't the library be installable?

@wpalfi
Copy link
Collaborator

wpalfi commented Nov 17, 2021

Probably, yes. I am just not a CMake expert and dont have time right now to figure out how to do that correctly for all possible configurations (header-only or not, platform, conan etc.). Happy to accept a pull request if it covers all of that.

@wpalfi wpalfi added the enhancement New feature or request label Nov 17, 2021
@joaocandre
Copy link
Author

joaocandre commented Nov 17, 2021

It is a minimal addition to the CMakeLists.txt (at least for the non-conan compilation, I'm not an user of conan so can't really help on that front).

I've submitted a pull request with a basic install routine. Tested on an up-to-date ArchLinux, but it should in theory extend to any linux distribution with a recent CMake version. Up to you to review it and decide.

wpalfi added a commit that referenced this issue Nov 18, 2021
@wpalfi
Copy link
Collaborator

wpalfi commented Nov 18, 2021

Thanks for the pull request! Just extended it to exclude ipp for non-header-only builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants