memoテーブル、memoモデルにuser_nameを追加する #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuri0616
temporarily deployed
to
github-pages
GitHub Actions
Inactive
kakeru-one
reviewed
Sep 17, 2024
backend/db/Schemafile
Outdated
| @@ -10,6 +10,7 @@ end | |||
| create_table 'memos', charset: 'utf8mb4', collation: 'utf8mb4_0900_ai_ci', force: :cascade do |t| | |||
| t.string 'title', null: false, comment: 'メモのタイトル' | |||
| t.text 'content', null: false, comment: 'メモの本文' | |||
| t.string 'user_name', limit: 21, null: false, comment: 'Slackのユーザー名' | |||
There was a problem hiding this comment.
[Must/Discussion]
投稿者の名前をuser_nameにしてしまうと、
単語的にusersテーブルのaccount_nameなのかなと思わせてしまいます。
contributorやposterといった命名が適切ではないでしょうか？
There was a problem hiding this comment.
あと、50文字まで許容した方がいいかなと思います！
kakeru-one
reviewed
Sep 17, 2024
backend/db/Schemafile
Outdated
| @@ -10,6 +10,7 @@ end | |||
| create_table 'memos', charset: 'utf8mb4', collation: 'utf8mb4_0900_ai_ci', force: :cascade do |t| | |||
| t.string 'title', null: false, comment: 'メモのタイトル' | |||
| t.text 'content', null: false, comment: 'メモの本文' | |||
| t.string 'user_name', limit: 21, null: false, comment: 'Slackのユーザー名' | |||
There was a problem hiding this comment.
あと、50文字まで許容した方がいいかなと思います！
backend/spec/requests/memos_spec.rb
Outdated
Comment on lines
75
to
76
| { title: Faker::Lorem.sentence(word_count: 3), content: Faker::Lorem.paragraph(sentence_count: 5), | ||
| user_name: Faker::Name.name } |
There was a problem hiding this comment.
idiomatic/Nits
改行が恣意的なので、慣習的になるようにしましょう.
Suggested change
| { title: Faker::Lorem.sentence(word_count: 3), content: Faker::Lorem.paragraph(sentence_count: 5), | |
| user_name: Faker::Name.name } | |
| { title: Faker::Lorem.sentence(word_count: 3), | |
| content: Faker::Lorem.paragraph(sentence_count: 5), | |
| user_name: Faker::Name.name } |
backend/spec/models/memo_spec.rb
Outdated
Comment on lines
79
to
86
| it 'valid?メソッドがfalseを返すこと' do | ||
| expect(memo).not_to be_valid | ||
| end | ||
|
|
||
| it 'errorsに「ユーザー名を入力してください」と格納されること' do | ||
| memo.valid? | ||
| expect(memo.errors.full_messages).to eq ['ユーザ名を入力してください'] | ||
| end |
There was a problem hiding this comment.
Performant/Simple
一つのitブロックにまとめられませんか？
他の部分に関しても同様なので、修正しましょう！
（過去のレビューから学ぶことも重要です！）
kuri0616
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応するissue
対応内容