-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/#101 implement memo search test #109
Open
shoutarou123
wants to merge
5
commits into
main
Choose a base branch
from
enhance/#101-implement-memo-search-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
76e54bd
テストコード追加
shoutarou123 8a6bf52
Merge branch 'main' into enhance/#101-implement-memo-search-test
shoutarou123 e538b99
memos_spec.rb修正
shoutarou123 9f46a56
githubのrspecエラーになるため記述追加
shoutarou123 d944a62
describeを削除し検索テストできるよう修正
shoutarou123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
RSpec.describe 'MemosController' do | ||
let!(:user) { create(:user) } | ||
|
||
# rubocop:disable RSpec/RepeatedExampleGroupDescription | ||
describe 'GET /memos' do | ||
let!(:memos) { create_list(:memo, 20) } | ||
|
||
|
@@ -60,6 +61,71 @@ | |
end | ||
end | ||
|
||
describe 'GET /memos' do | ||
let!(:first_memo) { create(:memo, title: 'メモタイトル1', content: 'メモコンテンツ1') } | ||
let!(:second_memo) { create(:memo, title: 'メモタイトル2', content: 'メモコンテンツ2') } | ||
let!(:third_memo) { create(:memo, title: 'その他タイトル', content: 'その他のコンテンツ') } | ||
|
||
context 'ログイン中かつ、タイトルが指定された場合' do | ||
before { sign_in(user) } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 上記2件のデータだけだと、部分一致検索ができている、いないにも関わらず2件ヒットすると思うので
と合致しないデータも含めた方が良いかなと思いました! |
||
|
||
it 'タイトルで部分一致するメモが返る' do | ||
aggregate_failures do | ||
get '/memos', params: { title: 'メモ' }, headers: { 'Accept' => 'application/json' } | ||
assert_request_schema_confirm | ||
assert_response_schema_confirm(200) | ||
expect(response.parsed_body['memos'].length).to eq(2) | ||
result_memo_ids = response.parsed_body['memos'].pluck('id') | ||
expect(result_memo_ids).to contain_exactly(first_memo.id, second_memo.id) | ||
end | ||
end | ||
end | ||
|
||
context 'ログイン中かつ、コンテンツが指定された場合' do | ||
before { sign_in(user) } | ||
|
||
it 'コンテンツで部分一致するメモが返る' do | ||
aggregate_failures do | ||
get '/memos', params: { content: 'メモ' }, headers: { 'Accept' => 'application/json' } | ||
assert_request_schema_confirm | ||
assert_response_schema_confirm(200) | ||
expect(response.parsed_body['memos'].length).to eq(2) | ||
result_memo_ids = response.parsed_body['memos'].pluck('id') | ||
expect(result_memo_ids).to contain_exactly(first_memo.id, second_memo.id) | ||
end | ||
end | ||
end | ||
|
||
context 'ログイン中かつ、並び順にascが指定された場合' do | ||
before { sign_in(user) } | ||
|
||
it '昇順でメモが返る' do | ||
aggregate_failures do | ||
get '/memos', params: { order: 'asc', title: 'タイトル' }, headers: { 'Accept' => 'application/json' } | ||
assert_request_schema_confirm | ||
assert_response_schema_confirm(200) | ||
result_memo_ids = response.parsed_body['memos'].pluck('id') | ||
expect(result_memo_ids).to eq([first_memo.id, second_memo.id, third_memo.id]) | ||
end | ||
end | ||
end | ||
|
||
context 'ログイン中かつ、並び順にdescが指定された場合' do | ||
before { sign_in(user) } | ||
|
||
it '降順でメモが返る' do | ||
aggregate_failures do | ||
get '/memos', params: { order: 'desc', title: 'タイトル' }, headers: { 'Accept' => 'application/json' } | ||
assert_request_schema_confirm | ||
assert_response_schema_confirm(200) | ||
result_memo_ids = response.parsed_body['memos'].pluck('id') | ||
expect(result_memo_ids).to eq([third_memo.id, second_memo.id, first_memo.id]) | ||
end | ||
end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ここも同様に昇順の場合、降順の場合でcontextをわけましょう! |
||
end | ||
end | ||
# rubocop:enable RSpec/RepeatedExampleGroupDescription | ||
|
||
describe 'GET /memos/:id' do | ||
let!(:memo) { create(:memo) } | ||
let!(:comments) { create_list(:comment, 3, memo: memo) } | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちら新たに
describe
を追加する必要はないかなと思いました!同様のPATHなので、今ある
describe 'GET /memos'
ブロックの中にテストを追加していくだけで良いと思いました。よってExampleの重複の警告を除外するrubocopの記述も不要となるかと思います!