コメントを更新するAPIを実装 #82
Merged
コメントを更新するAPIを実装 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakeru-one
reviewed
Aug 29, 2024
| context 'コンテンツが有効な場合' do | ||
| let(:memo) { create(:memo) } | ||
| let(:comment) { create(:comment, memo: memo) } | ||
| let(:valid_comment_params) { { content: Faker::Lorem.paragraph(sentence_count: 3) } } |
There was a problem hiding this comment.
Nits
名前が少し冗長かなと思いました！
paramsでいいかなと！
Suggested change
| let(:valid_comment_params) { { content: Faker::Lorem.paragraph(sentence_count: 3) } } | |
| let(:params) { { content: Faker::Lorem.paragraph(sentence_count: 3) } } |
| context 'バリデーションエラーになる場合' do | ||
| let(:memo) { create(:memo) } | ||
| let(:comment) { create(:comment, memo: memo) } | ||
| let(:invalid_comment_params) { { content: '' } } |
|
|
||
| it 'コメントが更新されていないこと、422になることを確認する' do | ||
| aggregate_failures do | ||
| put "/memos/#{memo.id}/comments/#{comment.id}", params: { comment: invalid_comment_params }, as: :json |
| context '存在しないコメントIDの場合' do | ||
| let(:memo) { create(:memo) } | ||
| let(:comment) { create(:comment, memo: memo) } | ||
| let(:valid_comment_params) { { content: Faker::Lorem.paragraph(sentence_count: 3) } } |
| context '存在しないメモIDの場合' do | ||
| let(:memo) { create(:memo) } | ||
| let(:comment) { create(:comment, memo: memo) } | ||
| let(:valid_comment_params) { { content: Faker::Lorem.paragraph(sentence_count: 3) } } |
| let(:comment) { create(:comment, memo: memo) } | ||
| let(:valid_comment_params) { { content: Faker::Lorem.paragraph(sentence_count: 3) } } | ||
|
|
||
| it '404が返ることを確認する' do |
There was a problem hiding this comment.
IMO
itブロックの文言には結果を書くのが慣習的なので、
「確認する」までは書かなくていいかなと思いました！
Suggested change
| it '404が返ることを確認する' do | |
| it '404が返る' do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応するissue
対応内容