Tracing #87
Merged
Tracing #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bird-dancer
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Sieht gut aus, es kann auch sein, dass die tracer initialisierung in einer extra util function besser wäre, musst du entscheiden. kannst du noch ins readme schreiben, wie man den tracer accessed. Es kann sein, dass das auch eine gut meta-information für @jacobGr-afk wäre 🤷♂️ .
Und wenn der immer aufgerufen wird, wäre es vlt. besser den in den listen for message zu packen, damit der handler nicht so voll ist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to expand this with traceIds, I think for it to make sense we need to call other services first (like a DB or auth server or sth). Our generated code is very general, so don't know how to integrate Jan's suggestions. Am open to ideas ofc.
Screenshot from Jaeger UI (basic.yaml):
