Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

53 split handler functions to different files in handler folder #89

Merged
merged 8 commits into from
Jul 9, 2023
Merged

53 split handler functions to different files in handler folder #89

merged 8 commits into from
Jul 9, 2023

Conversation

bird-dancer
Copy link
Member

  • now user templates can be read from folder work
  • handlers and producers are now split if they for example have
  • '$$handler$$' as their name
  • every file is rendered into the same sub path it came from
  • a lot of changes regarding generator functions
    ISSUES:
  • names inside generated code are still mangled, no snake case etc.

@bird-dancer
* dependencies are now embedded
ef78778 
* added extra functions for rendering embedded files
* render_multiple_embedded_templates now takes Iterable
* changed PathBuf to Path where possible
@bird-dancer
added a few comments
c52861e
@bird-dancer
split handler functions code much more modular
caa13a6
@bird-dancer
- now user templates can be read from folder work
0f0fdd8 
- handlers and producers are now split if they for example have
- $$handler$$ as their name
- every file is rendered into the same sub path it came from
- a lot of changes regarding generator functions
@bird-dancer bird-dancer linked an issue Jul 8, 2023 that may be closed by this pull request
split handler functions to different files in handler folder #53
Closed
stano45
stano45 approved these changes Jul 9, 2023
View reviewed changes
Copy link
Collaborator

@stano45 stano45 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nit: Der erste Buchstaben ist groß bei einer Datei, aber bei den anderen klein. Weiß nicht woran das liegt, vielleicht ist das das gleiche Problem wie bei @aikokal 's PR.

Edit: ich sehe jetzt dass die Branch nicht up to date ist, also vielleicht ist das hier schon beim Rebasen gelöst.

image

@bird-dancer
Merge remote-tracking branch 'origin/main' into 53-split-handler-func…
4217ed1 
…tions-to-different-files-in-handler-folder
@bird-dancer
* fixed merge
2167421 
* added to_lower as template function
@bird-dancer
fixed more merge stuff
b9b51d7
@bird-dancer
Merge remote-tracking branch 'origin/main' into 53-split-handler-func…
72d2ffb 
…tions-to-different-files-in-handler-folder
@bird-dancer bird-dancer merged commit b04eaa8 into main Jul 9, 2023
@aikokal aikokal mentioned this pull request Jul 9, 2023
Merged
@bird-dancer bird-dancer deleted the 53-split-handler-functions-to-different-files-in-handler-folder branch July 9, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stano45 stano45 stano45 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

split handler functions to different files in handler folder
2 participants
@bird-dancer @stano45