Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #23

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Cleanup #23

merged 2 commits into from
Jan 9, 2025

Conversation

levyishai
Copy link
Member

No description provided.

@Copilot Copilot bot review requested due to automatic review settings January 9, 2025 17:26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/main/java/frc/trigon/robot/poseestimation/apriltagcamera/AprilTagCamera.java:66

  • Removing the null check for estimatedRobotPose could lead to a NullPointerException if estimatedRobotPose is accessed elsewhere without checking for null.
return inputs.hasResult && inputs.poseAmbiguity < AprilTagCameraConstants.MAXIMUM_AMBIGUITY;

src/main/java/frc/trigon/robot/poseestimation/apriltagcamera/AprilTagCamera.java:111

  • The method calculateRobotPose() now returns null if hasValidResult() is false. Ensure that the caller of this method handles the potential null return value.
if (!hasValidResult()) return null;
@levyishai levyishai merged commit d3dc04a into main Jan 9, 2025
3 checks passed
@levyishai levyishai deleted the cleanup branch January 9, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant