Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes mypy issue #2340

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Fixes mypy issue #2340

merged 5 commits into from
Jun 9, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jun 8, 2021

Fixes https://github.com/Project-MONAI/MONAI/runs/2778490290?check_suite_focus=true#step:7:345

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

wyli added 5 commits June 8, 2021 23:49
@wyli
fixes-mypy
64095f6 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
temp test
2651b55 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
updat req.
d9219b0 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Revert "fixes-mypy"
e96466d 
This reverts commit da85539.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Revert "temp test"
dece05c 
This reverts commit 2651b55.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from madil90 and Nic-Ma June 8, 2021 22:54
@wyli
Copy link
Contributor Author

wyli commented Jun 8, 2021 •
edited
Loading

this is verified https://github.com/Project-MONAI/MONAI/runs/2778653950?check_suite_focus=true

a few tickets about this https://github.com/python/mypy/issues/ 10598 10600 10601

@wyli wyli requested a review from ericspod June 8, 2021 22:57
Nic-Ma
Nic-Ma approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wyli ,

Thanks for your quick fix.
May I know the root cause of this issue?

Thanks.

@wyli
Copy link
Contributor Author

wyli commented Jun 8, 2021

because mypy 0.9 introduced some changes...

@wyli wyli enabled auto-merge (squash) June 8, 2021 23:01
@wyli wyli merged commit 6476cee into Project-MONAI:dev Jun 9, 2021
@wyli wyli deleted the fixes-mypy branch June 30, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@madil90 madil90 Awaiting requested review from madil90

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyli @Nic-Ma