Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4531 test/update deps versions #4605

Merged
merged 10 commits into from
Jun 30, 2022
Merged

4531 test/update deps versions #4605

merged 10 commits into from
Jun 30, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jun 28, 2022

Fixes #4531
Fixes #4606

Description

  • pytorch 22.05 22.06
  • pytorch 1.8.2, 1.12.0
  • pytorch-ignite 0.4.9

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli and others added 7 commits June 28, 2022 19:17
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review June 30, 2022 07:09
This reverts commit 5167d65.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Jun 30, 2022

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Jun 30, 2022

/build

@wyli
Copy link
Contributor Author

wyli commented Jun 30, 2022

fyi, 22.05 has this error:

======================================================================
FAIL: test_consistency_0 (__main__.TestDynUNetWithInstanceNorm3dNVFuser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.8/site-packages/parameterized/parameterized.py", line 533, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "/opt/monai/tests/test_dynunet.py", line 151, in test_consistency
    torch.testing.assert_allclose(result, result_fuser)
  File "/opt/conda/lib/python3.8/site-packages/torch/testing/_deprecated.py", line 32, in inner_wrapper
    return_value = fn(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/torch/testing/_deprecated.py", line 80, in assert_allclose
    torch.testing.assert_close(
  File "/opt/conda/lib/python3.8/site-packages/torch/testing/_comparison.py", line 1304, in assert_close
    assert_equal(
  File "/opt/conda/lib/python3.8/site-packages/torch/testing/_comparison.py", line 1074, in assert_equal
    raise error_metas[0].to_error()
AssertionError: Tensor-likes are not close!

Mismatched elements: 262127 / 262144 (100.0%)
Greatest absolute difference: 8.843761682510376 at index (0, 0, 35, 8, 34) (up to 1e-05 allowed)
Greatest relative difference: 2552812.792890017 at index (0, 1, 18, 3, 25) (up to 0.0001 allowed)

but 22.06 works fine. The base image is updated to 22.06.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Jun 30, 2022

/build

@wyli wyli enabled auto-merge (squash) June 30, 2022 17:48
@wyli wyli merged commit edf3b74 into dev Jun 30, 2022
@wyli wyli deleted the update-key-deps branch June 30, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typing error with torch 1.12 update and test with new versions of dependencies
2 participants